So I was just doing some number crunching for fun and determined a good rule of thumb as to which set of mods causes a larger overall damage increase. I thought I would share it with the community.
I will use math to establish the projected breakpoints where each is better. With random number generation this is, of course, not ALWAYS going to be the case. We'll all have fights where the numbers don't match up, but this should be good as a rule of thumb.
First, some background math: So a set of 4 offense mods produces 10% offense, while a set of 4 crit damage mods produces 30% crit damage. There is also the triangle mods that can grant up to 36% crit damage. Base crit damage is 150% of regular damage.
So to begin with, let's compare without the crit damage triangle.
In 10 attacks, with 4 crits and 6 non-crits, an offense mod set will generate 10% additional damage for each non crit, and 15% for each crit, adding up to a total of 120% bonus damage in those 10 attacks. A crit damage set will generate 30% additional damage for each crit, and no bonus damage for non-crits, adding up to a total of 120% bonus damage.
In Simple math:
6 non crits 110% - 100% = 10% * 6 = 60%
4 crits 165% - 150% = 15% * 4 = + 60%
120% total damage increase from the set
Crit Damage Set
4 crits 180% - 150% = 30% * 4 = 120% total damage increase from the set
So we can see that this is the breakpoint for which set to use without a crit damage triangle mod. 4 out of 10 attacks is a 40% crit chance. If you have below that, the offense set will produce more damage. If you have above that, crit damage set will produce more damage.
So now let's analyze with the crit damage triangle.
In 11 attacks, 5 crits will produce (5 * 18.6%) 93% bonus damage, and 6 non-crits will produce 60% bonus damage for a total of 153% bonus damage. A crit damage set on five crits will produce (5 * 30%) 150% bonus damage.
In Simple Math:
Offense Set Mods
6 non-crits 110% - 100% = 10% * 6 = 60%
5 crits 204% - 186% = 18.6% * 5 = + 93%
153% total damage from the set
Crit Damage Set Mods
5 crits 216% - 186% = 30% * 5 = 150%
So we can see that at 5/11 = 45~% crit, offense mods slightly outweigh crit damage mods in output, but that any higher crit chance (outside of fractions of a percentage) shouldn't yield the same result. So, with a crit damage triangle, stack offense until you reach 46% crit, then switch to critical damage.
TLDR version: With a crit damage triangle, offense set mods are better until you reach 46% or higher crit chance. After that, Crit damage is better. Without a crit damage triangle, use offense set mods until 40% crit chance, then switch to crit damage set mods.
If you see any errors, or have pointers, feel free to post. I plan on later posting in this thread about crit chance vs. crit damage breakpoints as well.